Skip to content

[kumo] stabilize button tooltip triggers - #765

Open
ftzi wants to merge 1 commit into
cloudflare:mainfrom
ftzi:fix/button-tooltip-trigger-stability
Open

[kumo] stabilize button tooltip triggers#765
ftzi wants to merge 1 commit into
cloudflare:mainfrom
ftzi:fix/button-tooltip-trigger-stability

Conversation

@ftzi

@ftzi ftzi commented Aug 31, 2026

Copy link
Copy Markdown

Summary

  • Keep one Button tooltip trigger mounted while disabled or loading changes.
  • Keep LinkButton tooltip ownership stable while its rendered control changes between an anchor and a disabled button.
  • Preserve native disabled-button semantics and title-derived accessible names without nesting tooltips.

Regression coverage

Mounted toggle tests reproduce the old trigger replacement for Button disabled, Button loading, and LinkButton disabled, then assert that the wrapper trigger remains the same DOM node across each transition.

Testing

  • vp test run --root packages/kumo --project=unit src/components/button/button.test.tsx
  • pnpm run format:check
  • pnpm run lint
  • pnpm run typecheck
  • pnpm run ci:typecheck
  • pnpm run test
  • pnpm run test:ci
  • vp run build:kumo

  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: repository review automation runs after an external contributor opens the pull request
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant