Porting boringssl bindings over to use bssl-sys with bindgen instead of hardcoding them - #2585
Draft
emarteca wants to merge 1 commit into
Draft
Porting boringssl bindings over to use bssl-sys with bindgen instead of hardcoding them#2585emarteca wants to merge 1 commit into
emarteca wants to merge 1 commit into
Conversation
…of hardcoding them
1. Install `bindgen`:
```bash
cargo install bindgen-cli
2. Build BoringSSL with Rust bindings:
cmake -B /path/to/boringssl/build -S /path/to/boringssl \
-DRUST_BINDINGS=$(rustc -vV | sed -n 's/host: //p')
cmake --build /path/to/boringssl/build -j$(nproc)
3. Build / test quiche with --no-default-features --features boringssl-bssl-sys:
BORINGSSL_BUILD_DIR="/path/to/boringssl/build" \
cargo test --no-default-features --features boringssl-bssl-sys -p quiche
| } | ||
|
|
||
| /// See [`FfiSlice`]. | ||
| pub(crate) trait FfiMutSlice { |
There was a problem hiding this comment.
Ah I suppose this trait is published from bssl-crypto crate now. We could import it eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install
bindgen: ```bash cargo install bindgen-cliBuild BoringSSL with Rust bindings: cmake -B /path/to/boringssl/build -S /path/to/boringssl \ -DRUST_BINDINGS=$(rustc -vV | sed -n 's/host: //p') cmake --build /path/to/boringssl/build -j$(nproc)
Note: you can use the path to boringssl that is included through cargo
Build / test quiche with --no-default-features --features boringssl-bssl-sys: BORINGSSL_BUILD_DIR="/path/to/boringssl/build" \ cargo test --no-default-features --features boringssl-bssl-sys -p quiche