fix(cache): classify explicit io probes - #3097
Open
james-elicx wants to merge 4 commits into
Open
Conversation
commit: |
Contributor
|
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
from
August 26, 2026 15:14
afde0d2 to
eebc6e4
Compare
james-elicx
changed the base branch from
codex/cacheability-use-cache-ownership
to
codex/cacheability-fill-publication
August 26, 2026 15:41
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
from
August 26, 2026 18:01
eebc6e4 to
3ba0ec6
Compare
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
2 times, most recently
from
August 26, 2026 18:31
72a2e52 to
6d73915
Compare
james-elicx
changed the base branch from
codex/cacheability-fill-publication
to
codex/cacheability-unstable-cache-upgrade
August 26, 2026 18:31
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
from
August 26, 2026 19:33
6d73915 to
c482584
Compare
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
from
August 26, 2026 19:42
c482584 to
cec612c
Compare
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
from
August 27, 2026 02:25
cec612c to
80cc25c
Compare
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
2 times, most recently
from
August 27, 2026 02:40
a90a838 to
8df02a7
Compare
james-elicx
force-pushed
the
codex/cacheability-platform-io
branch
from
August 27, 2026 02:43
8df02a7 to
4311d92
Compare
Member
Author
|
/bigbonk review for issues |
Contributor
|
@james-elicx Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
james-elicx
marked this pull request as ready for review
August 27, 2026 08:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up stack 2/2. Exact head:
4311d92858fb18d6356fbd16b6de8bde0a14ab98. Base: #3099 at7ab2b603d.Chain: #3099 → #3097.
This layer closes the explicit
io()ownership and post-certification admission gap for Cache Components:io()notifies the outer render owner before returning its hanging promise, so a surrounding Suspense fallback cannot complete and be certified as staticio()remains a no-op inside"use cache"andunstable_cache()scopes, matching Next.js even though vinext models those owners in separate async-local stateio()does not demote those routesio()is a no-op in Pages GSSP, GSP, and component renderingio()branch after an edge purge to fail closed before public CDN policy is restoredThe built-workerd regression covers both sides of the lifecycle: authenticated probing classifies direct App
io()as dynamic while proving a hybrid PagesReact.use(io())render completes, and a route certified through its static branch remains private when later application state selectsio()after the warmed edge object is purged. A second request proves the private refill did not re-warm the edge.This PR deliberately does not instrument
Date,Math, Web Crypto, or Node crypto. Platform-I/O parity is separate from the request-derived cache disclosure fix and requires a design that does not rewritenode:cryptoimports.Next.js references:
Review size
Layer-only diff against #3099: 20 files, +425/-23.
Validation
vp checkgit diff --check