Move volatile-cache to workerd#1666
Merged
Merged
Conversation
c3d4118 to
d13d97a
Compare
kentonv
reviewed
Feb 13, 2024
kentonv
reviewed
Feb 13, 2024
b3a28c6 to
9375d63
Compare
Collaborator
Author
|
Do we want to mark this experimental initially until we're ready to enable this in production or is landing it without the experimental flag ok here? |
Collaborator
|
Really seems like needs to be experimental flag. |
Collaborator
Author
|
Given that this is renamed, it will no longer conflict with |
kentonv
reviewed
Feb 15, 2024
kentonv
reviewed
Feb 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
97b6d5c to
5023de9
Compare
fd68ef1 to
a2c6bea
Compare
kentonv
reviewed
Feb 28, 2024
a2c6bea to
cc026f6
Compare
kentonv
reviewed
Feb 29, 2024
kentonv
reviewed
Feb 29, 2024
cc026f6 to
1ee1e0f
Compare
Collaborator
Author
|
Updated in 1ee1e0f |
1ee1e0f to
3d9d698
Compare
cda0b78 to
e20b243
Compare
kentonv
reviewed
Mar 6, 2024
kentonv
approved these changes
Mar 6, 2024
e20b243 to
c5e9895
Compare
mikea
approved these changes
Mar 6, 2024
c5e9895 to
c2488c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First steps to moving volatile-cache to workerd. This will remain draft until the tests are also ported and the internal PR switching over to this is opened.
This is effectively a straightforward port of the version in the internal repo with a callback hook replacing some of the internal-specific additional limits we enforce when resizing.
Key questions to answer:
Should we rename the API before it lands here? What should the name be?Renamed toMemoryCache(at least for now)Should any changes be made to the API before it lands here? What changes?getInstance(...) method changed to also accept theownerIdvirtual interface added to abstract the actual implementation of the cache mapShould any changes be made to the binding configuration before it lands here? What changes?id field is now optionalShould the implementation be updated to use memcache now or later?