fix(runtime-sdk): chain the app's exception onto a reported lifespan failure - #237
Open
whitphx wants to merge 1 commit into
Open
fix(runtime-sdk): chain the app's exception onto a reported lifespan failure#237whitphx wants to merge 1 commit into
whitphx wants to merge 1 commit into
Conversation
whitphx
marked this pull request as draft
August 29, 2026 12:49
…failure A reported startup or shutdown failure surfaced as a bare RuntimeError carrying only the message text, so the app's own exception reached callers nowhere. Frameworks re-raise it right after sending the failed event, and in that same-tick case the awaiter has not resumed, so attaching it there delivers it as the reported error's cause.
whitphx
force-pushed
the
fix/asgi-lifespan-chain-cause
branch
from
August 30, 2026 02:56
1d73c14 to
f7783dd
Compare
whitphx
marked this pull request as ready for review
August 30, 2026 05:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an app reports
lifespan.startup.failed, the caller gets aRuntimeErrorcarrying only the message text, so the app's own exception object reaches nobody. This attaches it as the reported error's__cause__, on the startup and shutdown paths alike.Test Plan
(run from
packages/runtime-sdk)