feat(runtime-sdk): Add serialize option in WSGI entrypoint - #240
Open
ryanking13 wants to merge 4 commits into
Open
feat(runtime-sdk): Add serialize option in WSGI entrypoint#240ryanking13 wants to merge 4 commits into
serialize option in WSGI entrypoint#240ryanking13 wants to merge 4 commits into
Conversation
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we discussed internally, this adds a
serializeoption to wsgi handler so that users can serialize each request if there applications are not async safe.Originally, I thought we should add this to
asgiref.sync.sync_to_async, but I realized that WSGI applications don't useasgiref.sync.sync_to_asyncat all, and it is for using synchronous ORMs inside async handlers in ASGI applications. So I ended up locking the entire request.We can probably add the same option to asgi.py as well, but asgi.py is a bit more compliated due to lifespans, so I would like to discuss and land this to wsgi first.