DRAFT fix(runtime-sdk): fix broken entropy patches - #241
Draft
ryanking13 wants to merge 1 commit into
Draft
Conversation
ryanking13
marked this pull request as draft
August 31, 2026 09:16
![ask-bonk[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| from tests import ( | ||
| test_aiohttp_websocket, | ||
| test_langsmith, | ||
| test_pydantic, |
There was a problem hiding this comment.
test_numpy is not imported, so this snapshot test no longer exercises the NumPy entropy patches that the previous pytest.main() collection covered. Include it in the snapshot imports.
Suggested change
| test_pydantic, | |
| test_langsmith, | |
| test_numpy, |
|
I'm Bonk, and I've done a quick review of your PR. This moves entropy-import checks into snapshot-time module imports.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out entropy tests were not properly working. Since test files were not picked up during the worker initialization, they were not included during the snapshot creation and was failing to detect entropy errors.