Skip to content

fix: removed ts-ignore - #535

Merged
colbyfayock merged 2 commits into
cloudinary-community:mainfrom
Yash-sudo-web:main
Oct 4, 2024
Merged

fix: removed ts-ignore#535
colbyfayock merged 2 commits into
cloudinary-community:mainfrom
Yash-sudo-web:main

Conversation

@Yash-sudo-web

@Yash-sudo-web Yash-sudo-web commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

Description

Removed ts-ignore from CldVideoPlayer.tsx

Issue Ticket Number

Fixes #426

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation
@vercel

vercel Bot commented Oct 4, 2024

Copy link
Copy Markdown

@Yash-sudo-web is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.
@Yash-sudo-web Yash-sudo-web mentioned this pull request Oct 4, 2024
Closed
@colbyfayock

colbyfayock commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

@Yash-sudo-web the type has been released on @cloudinary-util/types@1.5.10

Can you update the dependency in this PR and confirm its working?
@Yash-sudo-web

Yash-sudo-web commented Oct 4, 2024

Copy link
Copy Markdown
Contributor Author

hey @colbyfayock , i tried installing @cloudinary-util/types@1.5.10, it was giving some other errors and the project was not running, but on @cloudinary-util/types@1.5.8, i added the type by going into the node_modules folder and it was working fine, no errors were thrown
@colbyfayock

colbyfayock commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

ah, yeah thats an issue with how the /url-loader is built, if theres a version mismatch, it'll create an issue. i forced a version for the one dependency that was having an issue and updated both
@vercel

vercel Bot commented Oct 4, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Oct 4, 2024 3:41pm
@Yash-sudo-web

Yash-sudo-web commented Oct 4, 2024

Copy link
Copy Markdown
Contributor Author

oh okay, that makes sense, i thought maybe new versions for these deps would be officially released later or something
this should be good to go then?
@colbyfayock

colbyfayock commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

Yup, good to go, thank you!
@colbyfayock
colbyfayock merged commit 32931c9 into cloudinary-community:main Oct 4, 2024
@colbyfayock

colbyfayock commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

@all-contributors please add @Yash-sudo-web for code
@allcontributors allcontributors Bot mentioned this pull request Oct 4, 2024
Merged
@allcontributors

allcontributors Bot commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

@colbyfayock

I've put up a pull request to add @Yash-sudo-web! 🎉
@colbyfayock

colbyfayock commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

@Yash-sudo-web thanks for the contribution.

This PR is eligible for free Hacktoberfest swag! Please send me an email with your name, GitHub username, and a link to this PR to hacktoberfest@cloudinary.com where I'll send further instructions.
github-actions Bot pushed a commit that referenced this pull request Oct 4, 2024
@semantic-release-bot
chore(release): 6.14.1 [skip ci]
d410541 
## [6.14.1](v6.14.0...v6.14.1) (2024-10-04)

### Bug Fixes

* removed ts-ignore ([#535](#535)) ([32931c9](32931c9)), closes [#426](#426)
@github-actions

github-actions Bot commented Oct 4, 2024

Copy link
Copy Markdown

🎉 This PR is included in version 6.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀
colbyfayock pushed a commit that referenced this pull request Oct 4, 2024
@allcontributors
docs: add Yash-sudo-web as a contributor for code (#536)
ff68bf7 
Adds @Yash-sudo-web as a contributor for code.

This was requested by colbyfayock [in this
comment](#535 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
github-actions Bot pushed a commit that referenced this pull request Oct 14, 2024
@semantic-release-bot
chore(release): 7.0.0-beta.3 [skip ci]
48a800f 
# [7.0.0-beta.3](v7.0.0-beta.2...v7.0.0-beta.3) (2024-10-14)

### Bug Fixes

* removed ts-ignore ([#535](#535)) ([32931c9](32931c9)), closes [#426](#426)
* use more proper type to derive `CldVideoPlayerProps` ([#537](#537)) ([65c3dd1](65c3dd1))

### Features

* added unique id generation using React's `useId()` hook ([#529](#529)) ([682f4c2](682f4c2)), closes [#493](#493)
@github-actions

github-actions Bot commented Oct 14, 2024

Copy link
Copy Markdown

🎉 This PR is included in version 7.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment