Skip to content

Add trigger on idle hook - #591

Open
pawelphilipczyk-cloudinary wants to merge 3 commits into
mainfrom
use-trigger-on-idle-hook
Open

Add trigger on idle hook#591
pawelphilipczyk-cloudinary wants to merge 3 commits into
mainfrom
use-trigger-on-idle-hook

Conversation

@pawelphilipczyk-cloudinary

@pawelphilipczyk-cloudinary pawelphilipczyk-cloudinary commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

Description

Added a better cleanup effect for the callback, regardless if it's a timeout or idle callback request.

Issue Ticket Number

Fixes #587

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation
@vercel

vercel Bot commented Jun 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Jun 5, 2025 7:06am
@eportis-cloudinary

Copy link
Copy Markdown
Contributor

Testing this with @yawuxi ’s original reduced example in #587, I still end up with duplicate iframes. Digging into why...
Screenshot 2025-06-06 at 13 57 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants