Skip to content

fix typo and upgrade source versions #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix typo and upgrade source versions #260

wants to merge 1 commit into from

Conversation

@krupakar0307
Copy link

@krupakar0307 krupakar0307 commented Jan 25, 2025 •
edited
Loading

what

  • This changes are upgrade of source versions, current source versions are not supporting latest terraform version (i.e >=1.10.5)
  • There is a typo in README.yaml under module ecs_alb_service_task line container_definition_json, the value should be module.container_definition.json_map_encoded_list instead of module.container_definition.json

why

  • To support latest terraform version and to fix typo for container_defination_json object in ecs_alb_service_task module.
  • This changes were made to support the current terraform version. the current source versions are very older.
  • Reference for typo link here, can find under module "ecs_alb_service_task" of container_definition_json line.
@krupakar0307 krupakar0307 requested review from a team as code owners January 25, 2025 09:45
@mergify mergify bot added the triage Needs triage label Jan 25, 2025
@RoseSecurity
Copy link
Contributor

RoseSecurity commented Jan 27, 2025

/terratest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Needs triage

3 participants

@krupakar0307 @RoseSecurity @shirisha-1910