Adding skip_destroy attribute to ECS Task Definition #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/terratest |
|
💥 This pull request now has conflicts. Could you fix it @cbergeron1? 🙏 |
oycyc
approved these changes
May 31, 2025
Contributor
oycyc
left a comment
oycyc
left a comment
There was a problem hiding this comment.
@cbergeron1 this looks good! There's a conflict now though, can you rerun building the docs?
|
💥 This pull request now has conflicts. Could you fix it @cbergeron1? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adding the new
skip_destroyattribute to the ECS Task Definition to allow users to retain the old versions of the task definitions via TF.why
This attribute is newly added to this resource, and would be nice to take advantage of it's functionality.
references
Closes #258