Skip to content

fix(comment-checker): bump dependency to ^0.7.0 for --prompt support#2131

Open
maou-shonen wants to merge 1 commit intocode-yeongyu:devfrom
maou-shonen:fix/comment-checker-dependency-version
Open

fix(comment-checker): bump dependency to ^0.7.0 for --prompt support#2131
maou-shonen wants to merge 1 commit intocode-yeongyu:devfrom
maou-shonen:fix/comment-checker-dependency-version

Conversation

@maou-shonen
Copy link

@maou-shonen maou-shonen commented Feb 26, 2026

Problem

I always felt like comment-checker wasn't doing anything when I had custom_prompt configured. After digging into it, turns out it's been silently failing every time.

465c9e51 added --prompt flag support, but package.json still has ^0.6.1. Since this is a 0.x package, caret semantics mean >=0.6.1 <0.7.0 — so v0.7.0 (which actually has the --prompt flag) never gets installed.

When v0.6.x receives an unknown flag, cobra exits with code 0. The hook treats exit 0 as "no comments detected", so the entire check is silently skipped with no error or warning.

Fix

Bump @code-yeongyu/comment-checker from ^0.6.1 to ^0.7.0.


Summary by cubic

Bumped @code-yeongyu/comment-checker to ^0.7.0 to add --prompt support. This fixes silent skips where v0.6.x treated the unknown flag as “no comments” when custom_prompt is set.

Written for commit acb51d1. Summary will update on new commits.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

@maou-shonen
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 26, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Corrects a version mismatch in package.json where a 0.x dependency was pinned too low to support a flag already being used. Fixes a silent failure with minimal risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant