test: fix determinism of CacheTest - #9967
Merged
paulbalandan merged 1 commit intoFeb 20, 2026
Merged
Conversation
paulbalandan
force-pushed
the
deterministic-cached-router-test
branch
from
February 20, 2026 12:45
5611b58 to
da494da
Compare
michalsn
approved these changes
Feb 20, 2026
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
vendor/bin/phpunit --filter Response,CodeIgniter\Router\Attributes\CacheTest::testAfterCachesGetRequestResponsewill fail because the previous test (testBeforeReturnsCachedResponseWhenFound()) pollutes the cache entries and response object. This can also be validated by runningvendor/bin/phpunit --filter CacheTest --order-by=random.To test, both mentioned should pass.
Checklist: