Skip to content

Refactor tests - #79

Open
petrduda wants to merge 2 commits into
consistence:masterfrom
petrduda:pd-refactor-tests
Open

Refactor tests#79
petrduda wants to merge 2 commits into
consistence:masterfrom
petrduda:pd-refactor-tests

Conversation

@petrduda

@petrduda petrduda commented Mar 9, 2023

Copy link
Copy Markdown
  • stop calling static methods in tests as non-static
  • use assertSame() where assertEquals() is not explicitly needed
  • use assertCount() after assertContains() for array comparison
  • add missing Assert::fail() in try+catch blocks when expecting exceptions
  • unify Assert::fail() message
  • replace Consistence\TestCase::ok() with expectNotToPerformAssertions()
  • use try+catch+fail when expecting exceptions with properties
  • rename data providers to singular where applicable
  • use DataProvider suffix for data providers
  • change data provider return type from array to Generator
  • declare data provider values on separate lines
  • isolate data provider cases using Closures
  • name data provider values
  • name data provider cases
  • extract multiple cases from test methods to data providers
  • remove unnecessary private methods for creating mocks

@VasekPurchart VasekPurchart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants