Skip to content

.gitignore vendor\pkg - #111

Closed
lowenna wants to merge 1 commit into
containerd:masterfrom
lowenna:gitignore
Closed

.gitignore vendor\pkg#111
lowenna wants to merge 1 commit into
containerd:masterfrom
lowenna:gitignore

Conversation

@lowenna

@lowenna lowenna commented Feb 25, 2016

Copy link
Copy Markdown

Signed-off-by: John Howard jhoward@microsoft.com

Same as for github.com/docker/docker

Signed-off-by: John Howard <jhoward@microsoft.com>
@stevvooe

Copy link
Copy Markdown
Member

To be compatible with the vendoring scheme in Go1.6, the vendor/src directory will actually have to be removed. The vendor/ directory shouldn't be treated as a GOPATH.

@lowenna

lowenna commented Feb 25, 2016

Copy link
Copy Markdown
Author

@stevvooe Sure, in time, but currently the dockerfile is using go 1.5.2, and I keep getting the vendor/pkg directory included in my repo git changes slowing me down trying to get this to compile on Windows.

@rakyll

rakyll commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

@stevvooe, moved the discussion to https://github.com/docker/containerd/issues/113. Go 1.6 is not required as long as the GO15VENDOREXPERIMENT flag is set, but I guess the switch is going to happen in the future.

@lowenna

lowenna commented Mar 1, 2016

Copy link
Copy Markdown
Author

So where does that leave this PR in the meantime? It's stuck in limbo land while not on 1.6 and the new vendoring scheme....

@stevvooe

stevvooe commented Mar 1, 2016

Copy link
Copy Markdown
Member

@jhowardmsft LGTM. No problem waiting for vendoring for this.

Another option is to add this to your global git config.

@crosbymichael

Copy link
Copy Markdown
Member

This should be resolved now that we updated the vendor layout.

jepio pushed a commit to jepio/containerd that referenced this pull request Dec 3, 2021
Add ToResources func for spec to v2.Resources
jseba pushed a commit to jseba/containerd that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants