chore: update Nixpacks version to 1.41.0 #7061
Conversation
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request bumps the NIXPACKS_VERSION argument in the Coolify helper Dockerfile from version 1.40.0 to 1.41.0. No logic, error handling, or dependencies are modified—just a straightforward version increment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes This is a straightforward version bump with no logic changes. The update is a single-line modification to a build argument—about as complicated as choosing between a crunchy or soft taco shell. Ah, a version upgrade to keep your self-hosted infrastructure running strong. I like it. None of that serverless nonsense that makes VC portfolios look good while your actual servers do the real work. This Nixpacks update will keep your Docker image lean and mean, the way infrastructure should be—tangible, controllable, and gluten-free of unnecessary abstractions. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
docker/coolify-helper/Dockerfile(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docker/**
📄 CodeRabbit inference engine (.cursor/rules/project-overview.mdc)
Store Docker configuration under docker
Files:
docker/coolify-helper/Dockerfile
| ARG PACK_VERSION=0.38.2 | ||
| # https://github.com/railwayapp/nixpacks/releases | ||
| ARG NIXPACKS_VERSION=1.40.0 | ||
| ARG NIXPACKS_VERSION=1.41.0 |
There was a problem hiding this comment.
Critical: NIXPACKS_VERSION variable is defined but never actually used.
The NIXPACKS_VERSION argument is declared but never passed to the install.sh script. The installation commands on lines 38 and 47 will always pull the latest version from nixpacks.com, making this version bump ineffective. This means the stated goal of supporting Node 24 won't be achieved.
The nixpacks install.sh script supports passing NIXPACKS_VERSION as an environment variable. Update the RUN commands to pass it:
- curl -sSL https://nixpacks.com/install.sh | bash
+ curl -sSL https://nixpacks.com/install.sh | NIXPACKS_VERSION=${NIXPACKS_VERSION} bashApply this fix to both lines 38 and 47:
RUN if [[ ${TARGETPLATFORM} == 'linux/amd64' ]]; then \
curl -sSL https://github.com/docker/buildx/releases/download/v${DOCKER_BUILDX_VERSION}/buildx-v${DOCKER_BUILDX_VERSION}.linux-amd64 -o ~/.docker/cli-plugins/docker-buildx && \
curl -sSL https://github.com/docker/compose/releases/download/v${DOCKER_COMPOSE_VERSION}/docker-compose-linux-x86_64 -o ~/.docker/cli-plugins/docker-compose && \
(curl -sSL https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz | tar -C /usr/bin/ --no-same-owner -xzv --strip-components=1 docker/docker) && \
(curl -sSL https://github.com/buildpacks/pack/releases/download/v${PACK_VERSION}/pack-v${PACK_VERSION}-linux.tgz | tar -C /usr/local/bin/ --no-same-owner -xzv pack) && \
- curl -sSL https://nixpacks.com/install.sh | bash && \
+ curl -sSL https://nixpacks.com/install.sh | NIXPACKS_VERSION=${NIXPACKS_VERSION} bash && \
chmod +x ~/.docker/cli-plugins/docker-compose /usr/bin/docker /usr/local/bin/pack /root/.docker/cli-plugins/docker-buildx \
;fiAnd the same fix for the arm64 block (line 47):
RUN if [[ ${TARGETPLATFORM} == 'linux/arm64' ]]; then \
curl -sSL https://github.com/docker/buildx/releases/download/v${DOCKER_BUILDX_VERSION}/buildx-v${DOCKER_BUILDX_VERSION}.linux-arm64 -o ~/.docker/cli-plugins/docker-buildx && \
curl -sSL https://github.com/docker/compose/releases/download/v${DOCKER_COMPOSE_VERSION}/docker-compose-linux-aarch64 -o ~/.docker/cli-plugins/docker-compose && \
(curl -sSL https://download.docker.com/linux/static/stable/aarch64/docker-${DOCKER_VERSION}.tgz | tar -C /usr/bin/ --no-same-owner -xzv --strip-components=1 docker/docker) && \
(curl -sSL https://github.com/buildpacks/pack/releases/download/v${PACK_VERSION}/pack-v${PACK_VERSION}-linux-arm64.tgz | tar -C /usr/local/bin/ --no-same-owner -xzv pack) && \
- curl -sSL https://nixpacks.com/install.sh | bash && \
+ curl -sSL https://nixpacks.com/install.sh | NIXPACKS_VERSION=${NIXPACKS_VERSION} bash && \
chmod +x ~/.docker/cli-plugins/docker-compose /usr/bin/docker /usr/local/bin/pack /root/.docker/cli-plugins/docker-buildx \
;fiThat said, you've got a slick self-hosted setup here. No serverless nonsense! "I'll be back... with tacos." 🌮
Also applies to: 38-38, 47-47
🤖 Prompt for AI Agents
In docker/coolify-helper/Dockerfile around lines 13, 38 and 47, the ARG
NIXPACKS_VERSION declared at line 13 is never used; update the two RUN lines
that invoke the nixpacks install script (both the amd64 and arm64 blocks) to
pass the argument as an environment variable when piping to install.sh. Modify
each RUN so the install invocation runs with NIXPACKS_VERSION set from the ARG
(e.g., prefix or export NIXPACKS_VERSION=${NIXPACKS_VERSION} when calling
sh/install.sh) so the install script uses the specified version rather than
pulling latest.
2 participants
Changes