Break background cache writes into batches of 100 #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
reviewed
Feb 17, 2020
bboreham
force-pushed
the
batch-background-cache
branch
from
2a6bdfe to
cf5d9b0
Compare
pracucci
reviewed
Feb 25, 2020
gouthamve
reviewed
Feb 28, 2020
| @@ -33,7 +33,7 @@ type BackgroundConfig struct { | |||
| // RegisterFlagsWithPrefix adds the flags required to config this to the given FlagSet | |||
| func (cfg *BackgroundConfig) RegisterFlagsWithPrefix(prefix string, description string, f *flag.FlagSet) { | |||
| f.IntVar(&cfg.WriteBackGoroutines, prefix+"memcache.write-back-goroutines", 10, description+"How many goroutines to use to write back to memcache.") | |||
| f.IntVar(&cfg.WriteBackBuffer, prefix+"memcache.write-back-buffer", 10000, description+"How many chunks to buffer for background write back.") | |||
| f.IntVar(&cfg.WriteBackBuffer, prefix+"memcache.write-back-buffer", 10000, description+"How many key batches to buffer for background write-back.") | |||
There was a problem hiding this comment.
Currently this means we can buffer 10000 * 100 = 1Mil chunks which is not something we want? Can we reduce it to 1000/100 = 10 batches at once? But this further means that if there are 10 writes each with a single key, then we'll only buffer 10 keys.
Not sure how to handle this simply.
There was a problem hiding this comment.
This is not a new problem; previously we could buffer 10000*(any number) chunks.
Suggest we deal with your point separately.
This improves parallelism and observability. Fixes #2134 Signed-off-by: Bryan Boreham <bryan@weave.works>
Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
batch-background-cache
branch
from
cf5d9b0 to
6ffe457
Compare
Signed-off-by: Bryan Boreham <bryan@weave.works>
Also comment one use of arbitrary integers in the test which is unrelated to test size. Signed-off-by: Bryan Boreham <bryan@weave.works>
bboreham
force-pushed
the
batch-background-cache
branch
from
8ad1589 to
565902d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves parallelism and observability of the background cache writes.
Which issue(s) this PR fixes:
Fixes #2134
Checklist
CHANGELOG.mdupdated