Skip to content

Fix wrong syntax for url in config-file-reference. #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

Fix wrong syntax for url in config-file-reference. #2148

merged 2 commits into from
Feb 18, 2020

Conversation

Wing924
Copy link
Contributor

@Wing924 Wing924 commented Feb 18, 2020 •
edited
Loading

Signed-off-by: Wing924 weihe924stephen@gmail.com

What this PR does:

git push --set-upstream origin fix-docs-url

AS IS:

externalurl:
  # URL of alerts return path.
  # CLI flag: -ruler.external.url
  [url: <url> | default = ]

TO BE:

# URL of alerts return path.
# CLI flag: -ruler.external.url
[externalurl: <url> | default = ]

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
@Wing924
Fix wrong syntax for url in config-file-reference.
a845f2a 
Signed-off-by: Wing924 <weihe924stephen@gmail.com>
@Wing924
fix
60fb0bf 
Signed-off-by: Wing924 <weihe924stephen@gmail.com>
pracucci
pracucci approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for spotting and fixing it!
jtlisi
jtlisi approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@pracucci pracucci merged commit e090642 into cortexproject:master Feb 18, 2020
@Wing924 Wing924 deleted the fix-docs-url branch February 19, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Wing924 @pracucci @jtlisi