Define store-gateway protobuf and client #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
define-store-gateway-protobuf
branch
from
26ccf9a to
953fdb2
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
define-store-gateway-protobuf
branch
from
953fdb2 to
7e9cda1
Compare
jtlisi
approved these changes
Apr 9, 2020
| "github.com/cortexproject/cortex/pkg/util/grpcclient" | ||
| ) | ||
|
|
||
| func NewStoreGatewayClientFactory(cfg grpcclient.Config, reg prometheus.Registerer) client.PoolFactory { |
There was a problem hiding this comment.
This doesn't look to be called anywhere? I assume it will be added in a consecutive PR.
There was a problem hiding this comment.
Exactly. I'm still in the process of submitting partial PRs in preparation of the final PR where I will submit the store-gateway and blocks sharding logic, otherwise the final one will be too huge to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I'm doing a step forward towards integrating the first version of the blocks storage
store-gatewayservice (proposal). In particular:store-gatewayservice, keeping it 100% compatible with the Thanos store (at the current stage won't be possible to build the consistency check because we lack the list of queried blocks in the response, but the consistency check will be added in a second phase and I would like to propose to expose blocks info in Thanos too)store-gatewayclient (that will be used by the querier) following the same approach we took for the ingester client (since thestore-gatewayclient will use the gRPC clients pool too)Notes to the reviewer:
store-gatewayprotobuf definition is in a separate package to avoid circular dependencies betweenquerierandstore-gateway(the querier needs thestore-gatewayprotobuf and, for a while, thestore-gatewayneeds the querier'sBucketStores)Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]