Add store-gateway support to querier #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
2 times, most recently
from
c99cad1 to
6c9ee92
Compare
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
from
6c9ee92 to
c55fe64
Compare
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
4 times, most recently
from
22e561f to
04acb27
Compare
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
2 times, most recently
from
a6d4e1c to
0f0e94f
Compare
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
from
0f0e94f to
8c48205
Compare
|
Thanks @pstibrany for your review! I've address your comments about errors wrapping/unwrapping. May you take a look, please? |
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
from
04c89d4 to
37b5549
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-store-gateway-support-to-querier
branch
from
37b5549 to
0da4003
Compare
|
@pstibrany I've unit tested |
3 tasks
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
* Add store-gateway support to querier Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed errors wrapping / unwrapping in blockStoreQuerier Signed-off-by: Marco Pracucci <marco@pracucci.com> * Use errors.Is() instead of errors.Unwrap() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Unit tested blocksStoreQuerier.SelectSorted() Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Following up #2458, in this PR I'm introducing the store-gateway support to queriers. Currently, store-gateways are opt-in so you can still use blocks synched/loaded in queriers (store-gateway will be made mandatory in a future PR, once we'll be confident enough with the store-gateway).
Out of the scope of this PR (to keep this PR "smaller"):
This PR is a draft because it's still lacking:
I've opened the draft to start collecting some feedback.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]