Skip to content

Add option to limit concurrent queries to Cassandra. #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2020

Conversation

tomwilkie
Copy link
Contributor

@tomwilkie tomwilkie commented May 5, 2020

Signed-off-by: Tom Wilkie tom@grafana.com

What this PR does:

Add an option to limit concurrent queries to Cassandra, to prevent us for DOSing the underlying clusters.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
Signed-off-by: Tom Wilkie <tom@grafana.com>
@tomwilkie tomwilkie force-pushed the cassandra-limit-queries branch from 982f798 to c82bdcb Compare May 5, 2020 19:11
Signed-off-by: Tom Wilkie <tom@grafana.com>
@tomwilkie tomwilkie marked this pull request as ready for review May 7, 2020 11:34
Signed-off-by: Tom Wilkie <tom@grafana.com>
Copy link
Contributor

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a flag name change.

Signed-off-by: Tom Wilkie <tom@grafana.com>
@gouthamve gouthamve merged commit 6b349a7 into master May 7, 2020
gouthamve pushed a commit to grafana/cortex that referenced this pull request May 7, 2020
)

* Add option to limit concurrent queries to Cassandra.

Signed-off-by: Tom Wilkie <tom@grafana.com>

* go mod vendor

Signed-off-by: Tom Wilkie <tom@grafana.com>

* Add changelog entry.

Signed-off-by: Tom Wilkie <tom@grafana.com>

* Review feedback.

Signed-off-by: Tom Wilkie <tom@grafana.com>
@gouthamve gouthamve deleted the cassandra-limit-queries branch May 7, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants