Expose TSDB checkpoint metrics from ingesters #2589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
May 13, 2020
CHANGELOG.md
Outdated
Comment on lines
71
to
74
| * `cortex_ingester_checkpoint_deletions_failed_total` | ||
| * `cortex_ingester_checkpoint_deletions_total` | ||
| * `cortex_ingester_checkpoint_creations_failed_total` | ||
| * `cortex_ingester_checkpoint_creations_total` |
There was a problem hiding this comment.
Should we use _tsdb_ in the name of these metrics?
There was a problem hiding this comment.
Definitely yes! Thanks for spotting the mistake 🤦
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
expose-tsdb-checkpoint-metrics-from-ingesters
branch
from
1478cee to
b695717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #2583 I forgot to expose checkpoint metrics. In this PR I'm amending it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]