Remove old temporary checkpoints #2726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmarchbanks
force-pushed
the
remove-old-tmp-checkpoints
branch
from
772af9e to
1ebd865
Compare
|
/cc @codesome |
codesome
reviewed
Jun 17, 2020
csmarchbanks
force-pushed
the
remove-old-tmp-checkpoints
branch
2 times, most recently
from
6db4264 to
7fd5907
Compare
codesome
approved these changes
Jun 22, 2020
pstibrany
approved these changes
Jun 22, 2020
If an ingester crashes while doing a checkpoint, which is likely as checkpoints are almost always happening, then a checkpoint like checkpoint.123456.tmp will be left on disk. When the next checkpoint succeeds, the old .tmp checkpoints are not deleted even though it will never be used. After enough crashes it is possible to fill the entire disk with .tmp checkpoints, bringing down an ingester. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks
force-pushed
the
remove-old-tmp-checkpoints
branch
from
7fd5907 to
44d2040
Compare
|
@pstibrany Thanks for pointing out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ingester crashes while doing a checkpoint, which is likely as
checkpoints are almost always happening, then a checkpoint like
checkpoint.123456.tmp will be left on disk. When the next checkpoint
succeeds, the old .tmp checkpoints are not deleted even though it will
never be used. After enough crashes it is possible to fill the entire
disk with .tmp checkpoints, bringing down an ingester.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]