Skip to content

Make Flusher mode to work with blocks-engine #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 16, 2020
Merged

Make Flusher mode to work with blocks-engine #2877

merged 8 commits into from
Jul 16, 2020

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Jul 15, 2020

What this PR does: This PR makes Flusher mode to work with blocks: by starting Cortex with flusher target, it will open all existing local TSDBs, flush data to blocks, upload these blocks to the storage and then exit. Note that currently the only error reporting is via logs -- Cortex exits gracefully even if flushing fails.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany pstibrany requested a review from pracucci July 15, 2020 09:53
@pstibrany pstibrany changed the title Make ingester' NewForFlush work with blocks-ingester too. Jul 15, 2020
@pstibrany pstibrany changed the title Make Flusher mode to work with blocks-engine too. Jul 15, 2020
…hutdown.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks solid to me, good job 👏 I left few nits, but no blocker.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany pstibrany merged commit 13695d1 into cortexproject:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants