Querier: Unset Host Header if DownstreamUrl is configured #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is necessary to correctly pass the Host Header to backend service. The Host Header will be set by stdlib, so flushing them should do the trick. Signed-off-by: Tim Foerster <tim.foerster@hetzner.com>
tonobo
force-pushed
the
fix-host-header-passing
branch
from
2bd079e to
480d2c1
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
approved these changes
Jul 15, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Jul 15, 2020
|
Cool! Thanks! |
tonobo
commented
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change is necessary to correctly pass the Host Header to backend
service. The Host Header will be set by stdlib, so flushing them should
do the trick.
Which issue(s) this PR fixes:
Fixes #2875
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]