Skip to content

Removed promql.lookback-delta option. #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Removed promql.lookback-delta option. #3144

merged 3 commits into from
Sep 9, 2020

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Sep 8, 2020

What this PR does: This PR removes obsolete -promql.lookback-delta option, deprecated since Cortex 1.2.

Which issue(s) this PR fixes:
Fixes #3116

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pstibrany pstibrany merged commit 6851acc into cortexproject:master Sep 9, 2020
CharlieTLe added a commit that referenced this pull request Dec 24, 2024
Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). #3144 

Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com>
@CharlieTLe CharlieTLe mentioned this pull request Dec 24, 2024
CharlieTLe added a commit to CharlieTLe/cortex that referenced this pull request Dec 24, 2024
Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). cortexproject#3144

Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
CharlieTLe added a commit that referenced this pull request Dec 24, 2024
Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). #3144

Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
friedrichg pushed a commit that referenced this pull request Dec 30, 2024
* Update arguments.md

Removed obsolete `-promql.lookback-delta` option (deprecated since Cortex 1.2, replaced with `-querier.lookback-delta`). #3144

Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>

* Rename `-querier.split-queries-by-day` to `-querier.split-queries-by-...

...interval`

Query-frontend: removed `-querier.split-queries-by-day` (deprecated in Cortex 0.4.0). Please use `-querier.split-queries-by-interval` instead. #3813
Signed-off-by: Charlie Le <charlie_le@apple.com>

* Fix typo and add description for `max_samples_per_query`

Flag `ingester.max-samples-per-query` was removed in #4812 as part of the chunk storage removal.

Signed-off-by: Charlie Le <charlie_le@apple.com>

* Remove 'Storage' section from arguments documentation

Removed in 73567bc#diff-ed3c6bb08ff3f85373c673fd92d1429599243584fc46d51a3221782263f26821L130

Signed-off-by: Charlie Le <charlie_le@apple.com>

* Update arguments.md

* Remove deprecated flag

Signed-off-by: Charlie Le <charlie_le@apple.com>

---------

Signed-off-by: Charlie Le <3375195+CharlieTLe@users.noreply.github.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants