Fix store-gateway sharding ring CLI flags prefix #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Sep 18, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
added a commit
that referenced
this pull request
Sep 18, 2020
* Fix store-gateway sharding ring CLI flags prefix Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated doc Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com>
3 tasks
pracucci
added a commit
that referenced
this pull request
Sep 18, 2020
* Fix store-gateway sharding ring CLI flags prefix Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated doc Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Sad but true, I misconfigured a couple of store-gateway CLI flags prefixes in the past. Since we're about to mark blocks storage stable in
1.4.0, in this PR I'm doing a last minute flag rename which I will backport to1.4.0too:-store-gateway.replication-factorflag renamed to-store-gateway.sharding-ring.replication-factor-store-gateway.tokens-file-pathflag renamed tostore-gateway.sharding-ring.tokens-file-pathWhich issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]