Expose doc for instance_interface_names #3295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
reviewed
Oct 7, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Oct 7, 2020
CHANGELOG.md
Outdated
| @@ -40,6 +40,11 @@ | |||
| - `POST <legacy-http-prefix>/push` | |||
| - `POST /push` | |||
| - `POST /ingester/push` | |||
| * [CHANGE] Renamed CLI flags to configure the network interface names from which automatically detect the instance IP. Not a breaking change because these flags were non documented. #3295 | |||
There was a problem hiding this comment.
Suggested change
| * [CHANGE] Renamed CLI flags to configure the network interface names from which automatically detect the instance IP. Not a breaking change because these flags were non documented. #3295 | |
| * [CHANGE] Renamed CLI flags to configure the network interface names from which automatically detect the instance IP. Not a breaking change because these flags were not documented. #3295 |
(or undocumented)
There was a problem hiding this comment.
There were documented in -help, I was using them in tests.
There was a problem hiding this comment.
You're right. -help shows everything. Removing that sentence.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The config documentation for
instance_interface_nameswas intentionally hidden to keep it simple, but there are legit use cases where our default interfaces don't cover actual ones.Which issue(s) this PR fixes:
Fixes #3293
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]