Support for specifying SSL certificates in Cassandra client #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfordcp
force-pushed
the
cassandra-client-certificates
branch
from
e1c5104 to
05bed5c
Compare
bradfordcp
changed the title
bradfordcp
force-pushed
the
cassandra-client-certificates
branch
from
8e053e2 to
834a3e8
Compare
|
Completed the checklist and squashed commits. Waiting for the checks to pass before submitting for review. |
pracucci
reviewed
Oct 26, 2020
|
I'll spend some cycles on getting this turned around tonight. Thanks for the review! |
bradfordcp
force-pushed
the
cassandra-client-certificates
branch
2 times, most recently
from
52decba to
4290b38
Compare
pracucci
approved these changes
Oct 27, 2020
bradfordcp
force-pushed
the
cassandra-client-certificates
branch
from
4290b38 to
be6a5c4
Compare
Updated tests Regenerated documentation Added CHANGELOG entry Signed-off-by: Christopher Bradford <christopher.bradford@datastax.com> Regenerate documentation and update certificate key file to private key file Signed-off-by: Christopher Bradford <christopher.bradford@datastax.com>
bradfordcp
force-pushed
the
cassandra-client-certificates
branch
from
be6a5c4 to
2d68517
Compare
|
Thanks for your patience, I'm surprised by the number of typos 😅 |
Thanks to you @bradfordcp. LGTM. Let me ping another maintainer for the 2nd review and then we can merge it. |
jtlisi
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Add support for Cassandra client SSL certificates
Which issue(s) this PR fixes:
Fixes #3383
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]