Improve compactor blocks cleaner when running with a large number of tenants #3483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tenants Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Nov 11, 2020
| @@ -270,7 +273,8 @@ func (c *Compactor) starting(ctx context.Context) error { | |||
| DataDir: c.compactorCfg.DataDir, | |||
| MetaSyncConcurrency: c.compactorCfg.MetaSyncConcurrency, | |||
| DeletionDelay: c.compactorCfg.DeletionDelay, | |||
| CleanupInterval: util.DurationWithJitter(c.compactorCfg.CompactionInterval, 0.05), | |||
| CleanupInterval: util.DurationWithJitter(c.compactorCfg.CompactionInterval, 0.1), | |||
There was a problem hiding this comment.
Increased a bit the jitter.
pstibrany
approved these changes
Nov 11, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
Thanks @pstibrany, I've addressed all your comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I'm testing the compactor in a cluster with a large number of tenants (6K) and I've found out the blocks cleaner doesn't scale. The problem is that cleaning 1 tenant at a time is too slow, so I'm proposing to add concurrency to it.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]