Upgrade Thanos and Prometheus #3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gouthamve
approved these changes
Nov 19, 2020
| @@ -165,7 +165,7 @@ message MetricMetadata { | |||
| } | |||
|
|
|||
| MetricType type = 1; | |||
| string metric_name = 2; | |||
| string metric_family_name = 2; | |||
There was a problem hiding this comment.
Does this break backwards compatibility?
There was a problem hiding this comment.
Also, why are we making this change? does it break anything?
There was a problem hiding this comment.
Field name changes don't break compatibility, as long as tag values are preserved.
There was a problem hiding this comment.
Does this break backwards compatibility?
No, field name change doesn't break it.
why are we making this change?
To keep the same exact naming of Prometheus, given the same struct is defined in Prometheus too now.
pstibrany
approved these changes
Nov 20, 2020
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I'm upgrading Thanos and Prometheus, in order to introduced the config option for the TSDB head chunks write buffer size. In details:
-blocks-storage.tsdb.head-chunks-write-buffer-size-bytesMetricMetadatafieldMetricNametoMetricFamilyNameto match naming in Prometheus (in this PR it has been added to Prometheus too 🎉 )I manually checked all Thanos changes and LGTM. There are no new Thanos metrics to map.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]