Support memcached max_item_size #3929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
commented
Mar 8, 2021
| @@ -183,6 +189,11 @@ func (c *memcachedClient) Stop() { | |||
| } | |||
|
|
|||
| func (c *memcachedClient) Set(item *memcache.Item) error { | |||
| // Skip hitting memcached at all if the item is bigger than the max allowed size. | |||
| if c.maxItemSize > 0 && uint64(len(item.Value)) > uint64(c.maxItemSize) { | |||
| return nil | |||
There was a problem hiding this comment.
Please let me know if you think it would be better to have a counter metric for this like thanos
There was a problem hiding this comment.
I would appreciate a metric similar to Thanos.
Signed-off-by: yeya24 <yb532204897@gmail.com>
yeya24
force-pushed
the
support-memcached-maxitemsize
branch
from
396879c to
ff0a498
Compare
pracucci
reviewed
Mar 9, 2021
pkg/chunk/cache/memcached_client.go
Outdated
| @@ -86,6 +90,7 @@ func (cfg *MemcachedClientConfig) RegisterFlagsWithPrefix(prefix, description st | |||
| f.UintVar(&cfg.CBFailures, prefix+"memcached.circuit-breaker-consecutive-failures", 10, description+"Trip circuit-breaker after this number of consecutive dial failures (if zero then circuit-breaker is disabled).") | |||
| f.DurationVar(&cfg.CBTimeout, prefix+"memcached.circuit-breaker-timeout", 10*time.Second, description+"Duration circuit-breaker remains open after tripping (if zero then 60 seconds is used).") | |||
| f.DurationVar(&cfg.CBInterval, prefix+"memcached.circuit-breaker-interval", 10*time.Second, description+"Reset circuit-breaker counts after this long (if zero then never reset).") | |||
| f.IntVar(&cfg.MaxItemSize, prefix+"memcached.max-item-size", 1024*1024, description+"The maximum size of an item stored in memcached. Bigger items are not stored. If set to 0, no maximum size is enforced.") | |||
There was a problem hiding this comment.
I would default it to 0, otherwise it's a "breaking change".
pkg/chunk/cache/memcached_client.go
Outdated
| @@ -52,6 +53,8 @@ type memcachedClient struct { | |||
| cbTimeout time.Duration | |||
| cbInterval time.Duration | |||
|
|
|||
| maxItemSize model.Bytes | |||
There was a problem hiding this comment.
No need to use model.Bytes. You can just use an int.
| @@ -183,6 +189,11 @@ func (c *memcachedClient) Stop() { | |||
| } | |||
|
|
|||
| func (c *memcachedClient) Set(item *memcache.Item) error { | |||
| // Skip hitting memcached at all if the item is bigger than the max allowed size. | |||
| if c.maxItemSize > 0 && uint64(len(item.Value)) > uint64(c.maxItemSize) { | |||
| return nil | |||
There was a problem hiding this comment.
I would appreciate a metric similar to Thanos.
Signed-off-by: yeya24 <yb532204897@gmail.com>
pracucci
approved these changes
Mar 10, 2021
pkg/chunk/cache/memcached_client.go
Outdated
| @@ -183,6 +196,12 @@ func (c *memcachedClient) Stop() { | |||
| } | |||
|
|
|||
| func (c *memcachedClient) Set(item *memcache.Item) error { | |||
| // Skip hitting memcached at all if the item is bigger than the max allowed size. | |||
| if c.maxItemSize > 0 && uint64(len(item.Value)) > uint64(c.maxItemSize) { | |||
There was a problem hiding this comment.
No need to cast to uint64:
Suggested change
| if c.maxItemSize > 0 && uint64(len(item.Value)) > uint64(c.maxItemSize) { | |
| if c.maxItemSize > 0 && len(item.Value) > c.maxItemSize { |
Signed-off-by: yeya24 <yb532204897@gmail.com>
roystchiang
pushed a commit
to roystchiang/cortex
that referenced
this pull request
Apr 6, 2022
* support memcached max_item_size configuration Signed-off-by: yeya24 <yb532204897@gmail.com> * add new metric Signed-off-by: yeya24 <yb532204897@gmail.com> * dont cast to uint Signed-off-by: yeya24 <yb532204897@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
What this PR does:
Add
max_item_sizesupport to Cortex Memcached client.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]