Skip to content

add charset attribute to script tag for simple-jekyll-search #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add charset attribute to script tag for simple-jekyll-search #1438

wants to merge 2 commits into from

Conversation

@chanwoo040531
Copy link

This PR adds the charset="utf-8" attribute to the <script> tag for simple-jekyll-search. This update ensures proper support for multilingual search.
@daattali
Copy link
Owner

I couldn't find any examples of other projects using this script line. Can you show me a usecase where not using this charset causes issues so that I can understand it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@chanwoo040531 @daattali