fix(tests): Specify top_level_dir to resolve tools module ambiguity in test discovery

[cmgzn]

Problem

When running tests in regression mode, unittest.TestLoader.discover() fails to locate test modules under tests/tools/ (e.g., test_mcp_server.py), resulting in test discovery returning None or empty test suites.

Root Cause:

The project has multiple tools directories that create namespace ambiguity:

• tests/tools/ - Contains test modules
• data_juicer/tools/ - Package module with dynamic import mechanism
• tools/ - Project-level utility scripts

When top_level_dir=None, the test loader cannot correctly resolve the import path for tests.tools.test_mcp_server, causing module resolution to fail.

Solution

Explicitly set top_level_dir=file_dir (project root) in test_loader.discover() to ensure unittest can correctly calculate the full import path for test modules, avoiding relative import resolution failures.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where unittest.TestLoader.discover() failed to locate test modules under tests/tools/ during regression testing. The problem arose from namespace ambiguity due to multiple tools directories within the project. By explicitly providing the top_level_dir to the test loader, the system can now correctly resolve import paths, enabling proper test discovery and execution.

Highlights

• Test Discovery Fix: Explicitly set the top_level_dir argument in unittest.TestLoader.discover() to resolve module ambiguity caused by multiple tools directories, ensuring correct test module location.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tests/run.py
  • Updated the unittest.TestLoader.discover() call to explicitly pass file_dir as the top_level_dir argument.

Activity

• No specific activity (comments, reviews, progress updates) was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a test discovery failure caused by namespace ambiguity with a tools directory. The fix involves explicitly setting the top_level_dir parameter in unittest.TestLoader.discover to the project's root directory. This ensures that test modules are imported with their full, unambiguous paths. The change is confined to tests/run.py and correctly resolves the described issue. I have no further suggestions for the changed code.