You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR removes DatePickerSingle and DatePickerRange as suggested in #148. It appears to have reduced the bundle size by about two thirds (!) from ~750KB to ~250KB.
While looking into ramda imports as suggested here I noticed that these two components were also the only places we were using ramda without targeted imports, so possibly a large chunk of the reduction we're getting is due to the blanket imports getting removed.
To help people use DatePicker{Single,Range} from dash-core-components, should we write an example in the documentation somewhere? The deprecation exception could then point to that?
To help people use DatePicker{Single,Range} from dash-core-components, should we write an example in the documentation somewhere? The deprecation exception could then point to that?
We could just link to the dash-core-components docs? I'm not sure that our own documentation would add much?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
DatePickerSingleandDatePickerRangeas suggested in #148. It appears to have reduced the bundle size by about two thirds (!) from ~750KB to ~250KB.