Skip to content

Kill date pickers#159

Merged
tcbegley merged 1 commit intomasterfrom
kill-datepickers
Apr 7, 2019
Merged

Kill date pickers#159
tcbegley merged 1 commit intomasterfrom
kill-datepickers

Conversation

@tcbegley
Copy link
Collaborator

This PR removes DatePickerSingle and DatePickerRange as suggested in #148. It appears to have reduced the bundle size by about two thirds (!) from ~750KB to ~250KB.

@tcbegley
Copy link
Collaborator Author

While looking into ramda imports as suggested here I noticed that these two components were also the only places we were using ramda without targeted imports, so possibly a large chunk of the reduction we're getting is due to the blanket imports getting removed.

@pbugnion
Copy link
Contributor

pbugnion commented Apr 5, 2019

To help people use DatePicker{Single,Range} from dash-core-components, should we write an example in the documentation somewhere? The deprecation exception could then point to that?

@pbugnion
Copy link
Contributor

pbugnion commented Apr 5, 2019

Apart from that, this looks good.

@tcbegley
Copy link
Collaborator Author

tcbegley commented Apr 5, 2019

To help people use DatePicker{Single,Range} from dash-core-components, should we write an example in the documentation somewhere? The deprecation exception could then point to that?

We could just link to the dash-core-components docs? I'm not sure that our own documentation would add much?

@tcbegley tcbegley merged commit 8ecf4b3 into master Apr 7, 2019
@tcbegley tcbegley deleted the kill-datepickers branch April 7, 2019 09:19
@ZeroCool2u
Copy link

@tcbegley @pbugnion Is there any documentation on how to apply the theme to the DateRangePicker components? I haven't had any luck so far.

@tcbegley
Copy link
Collaborator Author

@ZeroCool2u
Copy link

@tcbegley Great, thank you!

tcbegley added a commit that referenced this pull request Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants