Conversation
Use a number now instead of a date object / string. This is consitent with how *_timestamp props work in other components such as Button.
Collaborator
Author
|
The tests are failling because |
tcbegley
force-pushed
the
input-props-updates
branch
from
f37373e to
bb8de8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
Some props of
Inputthat map to HTML attributes were previously not camel cased and hence not applied correctly. While we could have built some kind of shim to pass these down to the underlying HTML elements, dash-core-components chose to rename them, and I think it makes sense to stay consistent with them. See their changelogUse timestamp rather than date object in
*_timestampprops inInput.