Improve badge for click tracking and links#268
Improve badge for click tracking and links#268tcbegley merged 1 commit intodbc-team:masterfrom miqh:feature/improve-badge
Conversation
tcbegley
left a comment
There was a problem hiding this comment.
Hey @miqh
Thanks so much for your contribution! Particularly for adding tests. I've somewhat neglected these to date as I've invested most of my time into improving documentation instead 😳 I definitely want to improve the state of the testing now that I'm mostly done with the docs for now.
I've made a couple of minor inline comments, really just for making this component consistent with other components that do similar things, specifically Button and DropdownMenuItem, and which I think helps readability a bit. If you are able to incorporate those I'd be happy to merge and include in the next release.
Thanks again for taking the time to contribute!
Extends the badge component to offer additional properties for tracking click interactions. Links are also rendered appropriately. Addresses #173
tcbegley
left a comment
There was a problem hiding this comment.
This is great, thanks again for your contribution!
Hello,
These changes aim to address the improvements suggested in #173.
I'm aware
n_clicks_timestampwasn't requested, but I figure I'd include it for consistency since most other components supportingn_clicksalso has the former.I transplanted the documentation for the new prop types from existing component implementations.
I've also introduced (couldn't find an existing one) a test file for the badge component that covers the new behaviour introduced.