Merged
Conversation
Jason-AM
reviewed
Nov 29, 2020
| * "/my-page" but not "/my-page/other" or "/random" | ||
| * - dbc.NavLink(..., href="/my-page", active="partial") will be active on | ||
| * "/my-page" and "/my-page/other" but not "/random" | ||
| */ |
Contributor
There was a problem hiding this comment.
Is is worth having an explanation of the format an href must take? From what I can see this doesn't account for someone using http://...
Collaborator
Author
There was a problem hiding this comment.
Yes, this is a good call. I'll try to clarify the docstring / documentation.
tcbegley
force-pushed
the
active-navlinks
branch
from
2eae238 to
cecefd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
NavLinkto automatically detectactivestate based on the current URL.activecan still be set toTrueorFalseto manually control whether theNavLinkshows as active or not, or can be set to either"exact"or"partial"with the following propertiesactive="exact"then theactivestyling will be applied if the current pathname exactly matches thehrefof theNavLink. For example,dbc.NavLink(..., href="/my-page")will automatically be active on/my-pagebut on no other page.active="partial"then theactivestyling will be applied if the current pathname starts with thehrefof theNavLink. For example,dbc.NavLink(..., href="/pets")is active on/pets,/pets/dogs,/pets/catsetc., but not on/random.