Merged
Conversation
* Added offcanvas components * Offcanvas doc snippets * Added offcanvas documentation * Fixed long text issue * Added react-bootstrap * Added offcanvas * Added offcanvas tests * Added js tests for offcanvas * Addition of new pagination component * Combined offcanvas into single component * Formatting * ABetter handling of pagination component * Updated pagination docs * Removed invalid code * Updated npm demo to Bootstrap 5 * Updated pagination docs to include R and jl * Updated pagination tests * Fixed callbacks * Reverted to 5.0.2 to avoid issues with offcanvas backdrop until resolved * Fixed offcanvas tests * Tidy up
* Accordion component and js test * Added documentation for accordion * R and Julia examples * Fixed h2 formatting issues * Added accordion folder for flake8 * Update demo/Demo.js Co-authored-by: glsdown <52132406+glsdown@users.noreply.github.com> Co-authored-by: Tom Begley <tomcbegley@gmail.com>
* Updated list-group component * Updated list-group docs
tcbegley
force-pushed
the
react-bootstrap
branch
from
8416b1e to
80e5d36
Compare
* Monkeypatch doc tests * Card * Nav and NavBar Update to Collapse to remove navbar prop * fixed Card.test.js for Card body test * updated docs for Navbar example. Also updated julia and R snippets * updates to Navbar and Collapse after review * updated index for deleted NavbarCollapse * lint and black Co-authored-by: tcbegley <tomcbegley@gmail.com>
tcbegley
added a commit
that referenced
this pull request
Sep 5, 2021
* Alert * Badge * Button * ButtonGroup * Carousel * Collapse * Fade * Add shim for html components that don't have class_name defined yet * Update block button docs * Update docs for Bootstrap 5 * RIP Jumbotron * Add react-bootstrap beta * Layout * Docs fix * Label * Clean up example * Monkeypatch doc tests * New components - Offcanvas and pagination (#643) * Added offcanvas components * Offcanvas doc snippets * Added offcanvas documentation * Fixed long text issue * Added react-bootstrap * Added offcanvas * Added offcanvas tests * Added js tests for offcanvas * Addition of new pagination component * Combined offcanvas into single component * Formatting * ABetter handling of pagination component * Updated pagination docs * Removed invalid code * Updated npm demo to Bootstrap 5 * Updated pagination docs to include R and jl * Updated pagination tests * Fixed callbacks * Reverted to 5.0.2 to avoid issues with offcanvas backdrop until resolved * Fixed offcanvas tests * Tidy up * Progress * Format tests * Spinner * Table * Toast * New component Accordion (#645) * Accordion component and js test * Added documentation for accordion * R and Julia examples * Fixed h2 formatting issues * Added accordion folder for flake8 * Update demo/Demo.js Co-authored-by: glsdown <52132406+glsdown@users.noreply.github.com> Co-authored-by: Tom Begley <tomcbegley@gmail.com> * flake8 config * List group updated to Bootstrap 5 (#647) * Updated list-group component * Updated list-group docs * Bug fixes * Tabs * Form * Form updates + examples * Checklist / RadioItems * Select * themes * BS5 updates for docs * Fix doc tests * InputGroup * Fix JS tests * Checkbox/Radio * format js * Modal * Modal docs * Fix format command * Card, Nav and Navbar (#648) * Monkeypatch doc tests * Card * Nav and NavBar Update to Collapse to remove navbar prop * fixed Card.test.js for Card body test * updated docs for Navbar example. Also updated julia and R snippets * updates to Navbar and Collapse after review * updated index for deleted NavbarCollapse * lint and black Co-authored-by: tcbegley <tomcbegley@gmail.com> * DropdownMenu * NavbarToggler * Tooltip+Popover * Consistent imports * Fix accordion tests * Initial breadcrumb component * Set accordion to first component * Format code * Update Breadcrumb * Snippet test fixes for breadcrumb * Popover - minor prop updates (#652) * Use size prop consistently Co-authored-by: glsdown <52132406+glsdown@users.noreply.github.com> Co-authored-by: AnnMarieW <72614349+AnnMarieW@users.noreply.github.com>
Merged
Merged
tcbegley
added a commit
that referenced
this pull request
Oct 19, 2021
* Alert * Badge * Button * ButtonGroup * Carousel * Collapse * Fade * Add shim for html components that don't have class_name defined yet * Update block button docs * Update docs for Bootstrap 5 * RIP Jumbotron * Add react-bootstrap beta * Layout * Docs fix * Label * Clean up example * Monkeypatch doc tests * New components - Offcanvas and pagination (#643) * Added offcanvas components * Offcanvas doc snippets * Added offcanvas documentation * Fixed long text issue * Added react-bootstrap * Added offcanvas * Added offcanvas tests * Added js tests for offcanvas * Addition of new pagination component * Combined offcanvas into single component * Formatting * ABetter handling of pagination component * Updated pagination docs * Removed invalid code * Updated npm demo to Bootstrap 5 * Updated pagination docs to include R and jl * Updated pagination tests * Fixed callbacks * Reverted to 5.0.2 to avoid issues with offcanvas backdrop until resolved * Fixed offcanvas tests * Tidy up * Progress * Format tests * Spinner * Table * Toast * New component Accordion (#645) * Accordion component and js test * Added documentation for accordion * R and Julia examples * Fixed h2 formatting issues * Added accordion folder for flake8 * Update demo/Demo.js Co-authored-by: glsdown <52132406+glsdown@users.noreply.github.com> Co-authored-by: Tom Begley <tomcbegley@gmail.com> * flake8 config * List group updated to Bootstrap 5 (#647) * Updated list-group component * Updated list-group docs * Bug fixes * Tabs * Form * Form updates + examples * Checklist / RadioItems * Select * themes * BS5 updates for docs * Fix doc tests * InputGroup * Fix JS tests * Checkbox/Radio * format js * Modal * Modal docs * Fix format command * Card, Nav and Navbar (#648) * Monkeypatch doc tests * Card * Nav and NavBar Update to Collapse to remove navbar prop * fixed Card.test.js for Card body test * updated docs for Navbar example. Also updated julia and R snippets * updates to Navbar and Collapse after review * updated index for deleted NavbarCollapse * lint and black Co-authored-by: tcbegley <tomcbegley@gmail.com> * DropdownMenu * NavbarToggler * Tooltip+Popover * Consistent imports * Fix accordion tests * Initial breadcrumb component * Set accordion to first component * Format code * Update Breadcrumb * Snippet test fixes for breadcrumb * Popover - minor prop updates (#652) * Use size prop consistently Co-authored-by: glsdown <52132406+glsdown@users.noreply.github.com> Co-authored-by: AnnMarieW <72614349+AnnMarieW@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Bootstrap 5.
Switching from reactstrap to React-Bootstrap behind the scenes as development has slowed on reactstrap and it's not clear when they will support Bootstrap 5, if ever.
TODO:
Components
AlertBadgeButtonButtonGroupCardCardBodyCardFooterCardGroupCardHeaderCardImgCardImgOverlayCardLinkCarouselCheckboxChecklistColCollapseContainerDropdownMenuDropdownMenuItemFadeFormFormFeedbackFormGroupFormTextInputInputGroupInputGroupTextLabelListGroupListGroupItemModalModalBodyModalFooterModalHeaderNavNavbarNavbarBrandNavbarSimpleNavbarTogglerNavItemNavLinkPopoverPopoverBodyPopoverHeaderProgressRadioButtonRadioItemsRowSelectSpinnerTab/TabsTableTextareaToastTooltipNew components
Some are new in Bootstrap 5, others are long outstanding omissions
AccordionBreadcrumbsFormFloatingModalTitleOffcanvasPaginationDeleted components
CardColumnsCardDeckInputGroupAddonJumbotronListGroupItemHeadingListGroupItemTextThemes
themes.py,themes.jl,themes.RMisc
className->class_nameis the issue here)sizeandbs_sizeare used consistently across components.Check docstrings all make sense(Leave this for later)PopoverandTooltipprops and defaults are all used correctly.