Skip to content

Stop loading_state being passed to components#666

Merged
tcbegley merged 2 commits intov1from
modal-loading-state-bug
Aug 31, 2021
Merged

Stop loading_state being passed to components#666
tcbegley merged 2 commits intov1from
modal-loading-state-bug

Conversation

@glsdown
Copy link
Contributor

@glsdown glsdown commented Aug 31, 2021

As documented in #651 , the modal components were being passed loading_state. I also identified a few other components where this was also the case, so I have fixed these.

@tcbegley tcbegley mentioned this pull request Aug 31, 2021
73 tasks
Copy link
Collaborator

@tcbegley tcbegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@tcbegley tcbegley merged commit 121c124 into v1 Aug 31, 2021
@tcbegley tcbegley deleted the modal-loading-state-bug branch August 31, 2021 21:02
tcbegley pushed a commit that referenced this pull request Sep 5, 2021
* Changed to zindex for consistency

* Stop loading_state being passed to component
This was referenced Sep 17, 2021
@tcbegley tcbegley mentioned this pull request Oct 9, 2021
@tcbegley tcbegley mentioned this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants