-
Notifications
You must be signed in to change notification settings - Fork 6
chore(deps): update definitelytyped #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughBumps dev-only TypeScript declaration versions in package.json: Pre-merge checks✅ Passed checks (3 passed)
Comment |
|
e7995d7 to
b6fd35b
Compare
b6fd35b to
136521d
Compare
136521d to
c44d7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
324357d to
b43aa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
package.json
[error] 1-1: Command failed with exit code 1: npm ci --prefer-offline --no-audit
b71a11c to
2b76688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
2276-2276: Clarify @types/temp vs runtime tmp package.Line 2276 references
@types/temp@^0.9.0, but the runtime dependency istmp@^0.2.4(line 2218). Verify these refer to the same package or clarify the intent.
3ba1ac3 to
68e1475
Compare
a227ea9 to
5e03827
Compare
ab89f99 to
95d3541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
95d3541 to
e2605bc
Compare
0f18ad5 to
6baaf92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
6baaf92 to
0cc3d8a
Compare
e1c040e to
e3fa0bc
Compare
e3fa0bc to
cdd2815
Compare
cdd2815 to
1903285
Compare
1903285 to
9b16e5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (3)
package.json (3)
2625-2625: Remove orphaned @types/temp: runtime temp package not present.The runtime
temppackage is not listed in dependencies. Having@types/temp^0.9.0 without the runtime package suggests unused type definitions—either remove the type definition or confirm the package is a transitive dependency.Likely an incorrect or invalid review comment.
2614-2614: Remove orphaned @types/react-json-tree dependency.The base package
react-json-treeis not installed, and@types/react-json-treeis unused throughout the codebase. Delete this dead dependency from package.json.
2610-2610: No action needed. pdfkit is not used in the codebase—the version bump for @types/pdfkit has no impact.
| "@types/sinon": "^10.0.15", | ||
| "@types/sinonjs__fake-timers": "^6.0.1", | ||
| "@types/stack-trace": "0.0.29", | ||
| "@types/stack-trace": "0.0.33", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch: @types/stack-trace vs stack-trace.
Types at 0.0.33 but runtime package at 0.0.10 (line 2560). Update runtime package or verify types compatibility.
🤖 Prompt for AI Agents
package.json around line 2621: the dev dependency "@types/stack-trace" is pinned
to 0.0.33 while the runtime "stack-trace" package is 0.0.10 (see ~line 2560);
resolve the version mismatch by either upgrading the runtime "stack-trace"
dependency to 0.0.33 to match the types, or pin "@types/stack-trace" to 0.0.10
(or remove the types package if the runtime bundles type definitions), then run
npm/yarn install and verify no type errors.
9b16e5b to
cb5168f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (1)
package.json (1)
2621-2621: Version mismatch already flagged.Types at 0.0.33 vs runtime
stack-traceat 0.0.10 (line 2560) already noted in past reviews.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
🔇 Additional comments (1)
package.json (1)
2610-2610: No pdfkit usage detected in the codebase, making the type/runtime version mismatch a non-issue. If pdfkit is unused, consider removing the dependency and its types rather than fixing version alignment.Likely an incorrect or invalid review comment.
| "@types/react": "^16.4.14", | ||
| "@types/react-dom": "^16.0.8", | ||
| "@types/react-json-tree": "^0.6.8", | ||
| "@types/react-json-tree": "^0.13.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for react-json-tree imports in codebase
echo "=== Searching for react-json-tree imports ==="
rg -n "react-json-tree" --type ts --type tsx --type js --type json -C2
echo ""
echo "=== Checking package.json structure around line 2614 ==="
# Get context around line 2614 in package.json
sed -n '2600,2630p' package.json
echo ""
echo "=== Checking if react-json-tree exists in devDependencies or dependencies ==="
rg '"react-json-tree"' package.jsonRepository: deepnote/vscode-deepnote
Length of output: 1530
🏁 Script executed:
#!/bin/bash
echo "=== Broader search for 'json-tree' (case-insensitive) ==="
rg -i "json-tree" --type-list | head -20
echo ""
echo "=== Search in all files for json-tree ==="
rg -i "json-tree" -C1
echo ""
echo "=== Check if react-json-tree might be accessed via namespace ==="
rg "react\." --type ts --type js | rg "json" | head -10
echo ""
echo "=== Verify what @types packages have runtime counterparts ==="
echo "Runtime dependencies section:"
sed -n '2501,2580p' package.json | grep -E '"react|"@types' | head -20Repository: deepnote/vscode-deepnote
Length of output: 3512
Remove @types/react-json-tree—it's deprecated. The package-lock.json flags it as a stub with a deprecation notice: "react-json-tree provides its own type definitions, so you do not need this installed." Removing this devDependency simplifies the setup while keeping type support intact.
🤖 Prompt for AI Agents
In package.json around line 2614, remove the devDependency entry
"@types/react-json-tree": "^0.13.0" because the upstream package provides its
own types; then run the package manager command (e.g. npm uninstall --save-dev
@types/react-json-tree or yarn remove @types/react-json-tree) and regenerate the
lockfile (npm install or yarn install) to update package-lock.json/yarn.lock so
the deprecated stub is removed.
| "@types/svg-to-pdfkit": "^0.1.0", | ||
| "@types/tcp-port-used": "^1.0.0", | ||
| "@types/temp": "^0.8.32", | ||
| "@types/temp": "^0.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for imports/requires of "temp" package
echo "=== Searching for 'temp' package usage ==="
rg "from ['\"]temp['\"]|require\(['\"]temp['\"]" --type ts --type js --type tsx --type jsx -C 2
echo ""
echo "=== Searching for 'tmp' package usage ==="
rg "from ['\"]tmp['\"]|require\(['\"]tmp['\"]" --type ts --type js --type tsx --type jsx -C 2Repository: deepnote/vscode-deepnote
Length of output: 226
🏁 Script executed:
#!/bin/bash
# Search more broadly for temp or tmp usage
echo "=== Searching for 'temp' usage anywhere ==="
rg "temp" -C 2 | head -50
echo ""
echo "=== Searching for 'tmp' usage anywhere ==="
rg "tmp" -C 2 | head -50
echo ""
echo "=== Check package.json around lines 2560-2630 ==="
sed -n '2560,2630p' package.jsonRepository: deepnote/vscode-deepnote
Length of output: 8418
Remove @types/temp; use only @types/tmp.
The codebase uses the tmp package (^0.2.4), not temp. Both packages are distinct. @types/temp appears unused; only @types/tmp is needed.
🤖 Prompt for AI Agents
package.json lines 2625-2625: The dev dependency "@types/temp" is incorrect for
this codebase (we use the "tmp" package); remove the "@types/temp" entry from
package.json, ensure "@types/tmp" is present in devDependencies, then run your
package manager (npm/yarn/pnpm) to update lockfile and node_modules and run
tests/build to confirm nothing broke.
This PR contains the following updates:
4.3.6→4.3.202.0.1→2.0.37.1.6→7.1.82.8.12→2.8.194.1.7→4.1.120.7.0→0.7.24.0.0→4.0.31.0.2→1.0.45.0.37→5.0.385.0.3→5.0.75.13.4→5.13.104.14.181→4.17.2118.19.31→18.19.13022.15.31→22.19.32.6.12→2.6.13^0.11.0→^0.17.00.4.0→0.4.316.9.14→16.9.25^0.6.8→^0.13.07.1.23→7.1.349.21.20→9.22.33.0.9→3.0.1310.0.15→10.0.200.0.29→0.0.332.0.1→2.0.40.1.0→0.1.31.0.1→1.0.4^0.8.32→^0.9.00.2.3→0.2.61.4.8→1.4.111.88.0→1.107.01.60.0→1.72.4Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.