-
Notifications
You must be signed in to change notification settings - Fork 1.2k
julia: Add support for workspaces #13446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ad000cf to
fea3924
Compare
fea3924 to
85f2aed
Compare
209f9d4 to
3427d5f
Compare
3427d5f to
fc828ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the following temporary dependabot yaml test file before approval.
julia/Julia-DependabotTest.yaml
e9fefa9 to
93a4fcb
Compare
663ab20 to
ae34f88
Compare
ae34f88 to
cac597a
Compare
2a04b1a to
3cfefba
Compare
|
I looked at the code and it seems well tested and made sense to me. I only had two small comments that I posted inline that are not super high priority (fixing the julia compat is easy though and should probably be done). |
What are you trying to accomplish?
This PR:
noticesfrom file_updater) i.e. for a workspace subpackage update where another subpackage doesn't have its compat updated (usually you'd group them together to avoid this..)Warning
The Julia package manager failed to update the new dependency versions in
/WorkspacePackage.jl/Manifest.toml:Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Analysis of results.yml
All 5 packages behave exactly as expected:1. BasicPackage ✅
Project.tomlonly (1 file)2. ManifestPackage ✅
Project.toml+Manifest.toml(2 files)Manifest.tomlsuccessfully updated3. VersionedManifestPackage ✅
Project.toml+Manifest-v1.12.toml(2 files)Manifest-v1.12.tomlsuccessfully updated4. SubPackageA ✅
Project.tomlonly (1 file)../Manifest.tomlNOT updated (conflicting sibling constraints)5. SubPackageB ✅
Project.tomlonly (1 file)../Manifest.tomlNOT updated (conflicting sibling constraints)Key Validations
✅ No manifests created where they didn't exist - BasicPackage correctly has only Project.toml updated
✅ Existing manifests were updated - ManifestPackage and VersionedManifestPackage both successfully updated their respective manifest files
✅ Workspace packages show proper notices - Both SubPackageA and SubPackageB display WARNING notices when manifest update fails
✅ Absolute paths in notices - User-facing messages show clear Manifest.toml instead of confusing
../Manifest.toml✅ Architecture is working - The simplified single-temp-directory approach allows Julia's Pkg to naturally discover workspace siblings and generate appropriate error messages
Checklist