Conversation
dexpota
left a comment
dexpota
left a comment
There was a problem hiding this comment.
Thank you for your contribution and I am sorry for the delay.
The review is mostly about the format of the header comment and the licensing information missing. If you can find that information please add it (if not it's not a problem.)
About the comment format, I am trying to introduce a little bit of structure to the themes so it can be easy to inspect them. TBD is a tool to help me and the contributors to format the themes correctly (author and licensing, fields order, etc..)
| @@ -0,0 +1,30 @@ | |||
| # BlackMetal by metalelf0, https://github.com/metalelf0 | |||
There was a problem hiding this comment.
Do you have any licensing information would you like to add?
| @@ -0,0 +1,20 @@ | |||
| # Corvine by arzg, https://github.com/arzg/vim-corvine | |||
There was a problem hiding this comment.
If you have any licensing information please add them below, from the GitHub repository I can see a LICENSE file. In this case, you could add these lines below:
# This work is licensed under the ISC License.
# For a copy, see https://github.com/arzg/vim-corvine/raw/master/LICENSE
| @@ -0,0 +1,21 @@ | |||
| # DesertNight by sainnhe | |||
There was a problem hiding this comment.
If you have any licensing information please add them below.
| @@ -0,0 +1,46 @@ | |||
| # GruvboxMaterial theme by sainnhe | |||
There was a problem hiding this comment.
If you have any licensing information please add them below.
| @@ -0,0 +1,46 @@ | |||
| # GruvboxMaterial theme by sainnhe | |||
There was a problem hiding this comment.
If you have any licensing information please add them below.
| # Kitty snow colors - dark | ||
| # Just copy the contents into your kitty config file | ||
|
|
||
| # Michael Chris Lopez (http://github.com/mcchrish) |
There was a problem hiding this comment.
Move this line to the top and change its format, if available add licensing information.
# Snow Dark by Michael Chris Lopez, http://github.com/mcchrish
# [Licensing if any]
| # Kitty snow colors - light | ||
| # Just copy the contents into your kitty config file | ||
|
|
||
| # Michael Chris Lopez (http://github.com/mcchrish) |
There was a problem hiding this comment.
Same comment as in SnowDark.conf.
| @@ -0,0 +1,44 @@ | |||
| ### srcery_kitty.conf | |||
There was a problem hiding this comment.
Change these lines to have the same format as the others.
# Srcery by srcery-colors, https://github.com/srcery-colors
# [Licensing information if any]
| @@ -0,0 +1,25 @@ | |||
| # Based on nightfly vim colorscheme by @bluz71 | |||
There was a problem hiding this comment.
# Based on https://github.com/bluz71/vim-nightfly-guicolors by bluz71
# Licensed under the terms of the MIT license.
# For a copy, see https://opensource.org/licenses/MIT.
| @@ -0,0 +1,40 @@ | |||
| # Drop these into your kitty.conf | |||
There was a problem hiding this comment.
# sourcerer by xero harrison, http://sourcerer.xero.nu
# [Licensing information if any]
# Based on sorcerer by Jeet Sukumaran (http://jeetworks.org)
# & mustang by Henrique C. Alves <hcarvalhoalves@gmail.com>
2 participants
Here are some themes I wrote or translated from other terminal themes in the last months. Hope you like ;)