Skip to content

fix: the appearance of indents when height = 1.0 or width = 1.0 - #461

Open
astrelinvl wants to merge 1 commit into
dmtrKovalenko:mainfrom
astrelinvl:fix/first-row
Open

fix: the appearance of indents when height = 1.0 or width = 1.0#461
astrelinvl wants to merge 1 commit into
dmtrKovalenko:mainfrom
astrelinvl:fix/first-row

Conversation

@astrelinvl

@astrelinvl astrelinvl commented May 9, 2026

Copy link
Copy Markdown

fix #366

@dmtrKovalenko

dmtrKovalenko commented May 11, 2026

Copy link
Copy Markdown
Owner

The problem with your change is that they apply to all sizes, not just fullscreen. Consider
width = 0.8, height = 0.8 (the defaults):
- center_col would be calculated as math.floor((200 - 160) / 2) - 1 = 19 instead of 20 — the picker shifts one cell left
- center_row shifts one cell upward similarly
- total_height gets an extra row that wasn't taken into account in the height calculation

@dmtrKovalenko

Copy link
Copy Markdown
Owner

can you please check on the main if you still have this issue?

@astrelinvl

Copy link
Copy Markdown
Author

When
prompt_position = 'top',
preview_position = 'right',

or

prompt_position = 'top',
preview_position = 'bottom',

or

prompt_position = 'bottom',
preview_position = 'bottom',

statusline is visible + borders are drawn incorrectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants