fix: queue send/steer safely during manual compaction#134
Merged
Conversation
Motivation: avoid dropped user input and invalid state transitions around manual compaction. Technical changes: - Queue C-c C-c/C-c C-s input locally while manual compaction is running. - Preserve steering input when steer send fails instead of clearing it. - Guard manual compact RPC with process liveness checks. - Extract helper functions for input acceptance/queueing and manual compaction response handling. - Add focused tests for compacting queue flow, steer failure, and dead/missing process guards.
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
Motivation: avoid dropped user input and invalid state transitions around manual compaction. Technical changes: - Queue C-c C-c/C-c C-s input locally while manual compaction is running. - Preserve steering input when steer send fails instead of clearing it. - Guard manual compact RPC with process liveness checks. - Extract helper functions for input acceptance/queueing and manual compaction response handling. - Add focused tests for compacting queue flow, steer failure, and dead/missing process guards.
dnouri
added a commit
that referenced
this pull request
Feb 26, 2026
Motivation: avoid dropped user input and invalid state transitions around manual compaction. Technical changes: - Queue C-c C-c/C-c C-s input locally while manual compaction is running. - Preserve steering input when steer send fails instead of clearing it. - Guard manual compact RPC with process liveness checks. - Extract helper functions for input acceptance/queueing and manual compaction response handling. - Add focused tests for compacting queue flow, steer failure, and dead/missing process guards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Manual compaction had edge cases where input handling could be inconsistent.
What
Validation