Prevent freezes when expanding large generic tool details#137
Merged
Conversation
dnouri
force-pushed
the
fix/large-tool-call-output-syntax
branch
from
0a3ad51 to
636350f
Compare
- mark generic Details payload as metadata via pi-coding-agent-no-fontify - on expand/collapse, fontify only non-metadata ranges - stop after first font-lock failure in a toggle pass; keep debug-only diagnostics - share rendered-content insertion between collapsed and expanded paths - add regressions for large details toggles, range splitting, non-nil exclusion values, and path-based generic tools
dnouri
force-pushed
the
fix/large-tool-call-output-syntax
branch
from
636350f to
b0dda53
Compare
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
- mark generic Details payload as metadata via pi-coding-agent-no-fontify - on expand/collapse, fontify only non-metadata ranges - stop after first font-lock failure in a toggle pass; keep debug-only diagnostics - share rendered-content insertion between collapsed and expanded paths - add regressions for large details toggles, range splitting, non-nil exclusion values, and path-based generic tools
dnouri
added a commit
that referenced
this pull request
Feb 26, 2026
- mark generic Details payload as metadata via pi-coding-agent-no-fontify - on expand/collapse, fontify only non-metadata ranges - stop after first font-lock failure in a toggle pass; keep debug-only diagnostics - share rendered-content insertion between collapsed and expanded paths - add regressions for large details toggles, range splitting, non-nil exclusion values, and path-based generic tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Expanding/collapsing large generic tool details (especially subagent output) could trigger expensive full-region markdown fontification and sometimes fail with
Stack overflow in regexp matcher.What changed
**Details**payload as metadata (pi-coding-agent-no-fontify)User-visible outcome
Verification
make checkgreen (655 tests)emacs -nw+tmux: