Silence missing-pi warnings in toggle unit tests#138
Merged
Conversation
dnouri
added a commit
that referenced
this pull request
Feb 25, 2026
dnouri
added a commit
that referenced
this pull request
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a test-only cleanup to remove noisy CI warnings like:
Error (pi): pi not found in PATH...from toggle/session unit tests that intentionally exercise window/session behavior without needing the real
pibinary.Changes
pi-coding-agent--check-dependenciesin the remaining toggle tests that were still calling real dependency checks.Why
The tests already mock process startup and are not validating dependency-check UX. Stubbing dependency checks keeps test output focused and stable in CI environments where
piis not installed.Verification
PATH=/usr/bin:/bin make test SELECTOR=toggle-now runs cleanly without missing-pi warnings.make checkpasses.