Skip to content

fix: make fork-at-point reliable in deep/large sessions#139

Merged
dnouri merged 1 commit intomasterfrom
fix/fork-at-point-deep-tree
Feb 23, 2026
Merged

fix: make fork-at-point reliable in deep/large sessions#139
dnouri merged 1 commit intomasterfrom
fix/fork-at-point-deep-tree

Conversation

@dnouri
Copy link
Copy Markdown
Owner

@dnouri dnouri commented Feb 23, 2026

Summary

  • fork-at-point now resolves entries via get_fork_messages.
  • mapping keeps visible-turn behavior in compacted sessions (last-N alignment).
  • explicit fork-at-point RPC error message for failed get_fork_messages responses.
  • RPC response dispatch now handles id-less responses by:
    1. matching pending request command type, then
    2. falling back to the sole pending request.

Tests

  • fork-at-point mapping tests: normal, compaction, deep history, before-first-heading.
  • fork-at-point explicit RPC failure message test.
  • core id-less response routing tests (command-match and sole-pending fallback).
  • process-exit cleanup test for pending command metadata.

Validation

  • make test
  • make check
@dnouri dnouri force-pushed the fix/fork-at-point-deep-tree branch from e808436 to 7198a20 Compare February 23, 2026 13:54
@dnouri dnouri changed the title fix: stop fork-at-point from crashing on deep chat trees Feb 23, 2026
@dnouri dnouri force-pushed the fix/fork-at-point-deep-tree branch from 7198a20 to e928c40 Compare February 23, 2026 14:08
@dnouri dnouri changed the title fix: restore fork-at-point on pi 0.54+ and deep sessions Feb 23, 2026
@dnouri dnouri force-pushed the fix/fork-at-point-deep-tree branch from e928c40 to 010accb Compare February 23, 2026 15:40
@dnouri dnouri changed the title fix: avoid deep-tree recursion overflow in fork-at-point Feb 23, 2026
@dnouri dnouri force-pushed the fix/fork-at-point-deep-tree branch from 010accb to 4ad9f65 Compare February 23, 2026 15:46
@dnouri dnouri force-pushed the fix/fork-at-point-deep-tree branch from 4ad9f65 to 0c50166 Compare February 23, 2026 15:52
@dnouri dnouri merged commit b4ee915 into master Feb 23, 2026
7 of 8 checks passed
@dnouri dnouri deleted the fix/fork-at-point-deep-tree branch February 23, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant