fix: use usable column count for display width (#178)#181
Merged
Conversation
Tables and tool-output previews overflowed when `display-line-numbers-mode' was active because the width calculation used `window-width', which includes the columns reserved for line numbers. Switch `--chat-window-width' to `window-max-chars-per-line', which returns only the columns available for buffer text. Consolidate the two bare `(or (window-width) 80)' calls in render.el behind the same accessor (now `--chat-display-width') so every consumer benefits from the fix. Defer the width query in streaming decoration until tree-sitter has actually found a table region, avoiding the call on the majority of deltas that contain no pipe tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables and tool-output previews overflowed when
display-line-numbers-modewas active because the widthcalculation used
window-width, which includes the columnsreserved for line numbers.
Switch
--chat-window-widthtowindow-max-chars-per-line,which returns only the columns available for buffer text.
Consolidate the two bare
(or (window-width) 80)calls inrender.el behind the same accessor (now
--chat-display-width)so every consumer benefits from the fix.
Defer the width query in streaming decoration until tree-sitter
has actually found a table region, avoiding the call on the
majority of deltas that contain no pipe tables.
Verified in both terminal and GUI (xvfb) Emacs — 830 unit tests green, 15/15 manual scenarios pass in each environment.