Keep syntax highlighting visible in edit diffs across themes#193
Merged
Keep syntax highlighting visible in edit diffs across themes#193
Conversation
dnouri
force-pushed
the
fix/theme-derived-edit-diff-faces
branch
from
0e21cea to
3f7df02
Compare
Before this change, edit diffs reused Emacs diff faces for whole lines. In themes that give those faces strong foreground colors, that could wash out the syntax highlighting inside the diff and make code harder to read. Now added and removed edit lines use theme-derived background tints while keeping the +/- indicators from diff-mode. That preserves syntax colors inside hot edit diffs, keeps the result consistent across dark and light themes, and gives failed tool blocks the same treatment. Tests cover theme-derived face selection, background-only overlays, and the regression where syntax highlighting must remain visible under edit diff overlays.
dnouri
force-pushed
the
fix/theme-derived-edit-diff-faces
branch
from
3f7df02 to
d4d1a6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, edit diffs reused Emacs diff faces for whole lines.
In themes that give those faces strong foreground colors, that could wash
out the syntax highlighting inside the diff and make code harder to read.
Now added and removed edit lines use theme-derived background tints while
keeping the +/- indicators from diff-mode. That preserves syntax colors
inside hot edit diffs, keeps the result consistent across dark and light
themes, and gives failed tool blocks the same treatment.
Tests cover theme-derived face selection, background-only overlays, and
the regression where syntax highlighting must remain visible under edit
diff overlays.